Bug#992700: xfig: Package FTBFS when built with 'nocheck'

[John Paul Adrian Glaubitz]

Source: xfig
Severity: normal
User: debian-***@lists.debian.org
Usertags: m68k
X-Debbugs-Cc: debian-***@lists.debian.org

Hello!

xfig fails to build from source when being built with 'nocheck'
set in DEB_BUILD_OPTIONS:

install -m755 tests/test1 `pwd`/debian/xfig/usr/libexec/xfig/
install: cannot stat 'tests/test1': No such file or directory
make[1]: *** [debian/rules:102: override_dh_install-arch] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:18: binary-arch] Error 2
dpkg-buildpackage: error: debian/rules binary-arch subprocess returned exit status 2

Full log in [1].

Thanks,
Adrian

[1] https://buildd.debian.org/status/fetch.php?pkg=xfig&arch=m68k&ver=1%3A3.2.8a-1&stamp=1629463312&raw=0

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - ***@debian.org
`. `' Freie Universitaet Berlin - ***@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

[John Paul Adrian Glaubitz]

Hi!

* Build test binaries despite of "nocheck" (Closes: #992700).

Does that mean that the testsuite is now run all the time?

The proper behavior should be that "nocheck" disables the testsuite since
being able to disable the testsuite is necessary for being able to cross-
compile a package.

Thanks,
Adrian

[Roland Rosenfeld]

Hi Adrian!

Post by John Paul Adrian Glaubitz

* Build test binaries despite of "nocheck" (Closes: #992700).

Does that mean that the testsuite is now run all the time?

No, it doesn't.
Upstream creates three little test binaries, that are used in the
upstream testsuite.
Since 3.2.8a-1 I place these test binaries in /usr/libexec/xfig on
build to be able to use them in autopkgtest. This has the advantage,
that autopkgtest uses test binaries that are build in the same
environment as the xfig binary, which is more realistic than building
these test binaries during autopkgtest, which may run in a different
environment than the original build.

So I do not run the testsuite here but only build and package the test
binaries.

Post by John Paul Adrian Glaubitz
The proper behavior should be that "nocheck" disables the testsuite since
being able to disable the testsuite is necessary for being able to cross-
compile a package.

No problem. But the above mentioned setup allows to run an
autopkgtest on the destination architecture (without need of a
compiler), since the test binaries are packaged.

BTW: https://salsa.debian.org/debian/xfig/-/pipelines/280000 shows,
that test-crossbuild-arm64 succeeded in the salsa pipeline :-)

Greetings
Roland